RFR: 8255036: Shenandoah: need to reset GC state for root verifier

Roman Kennke rkennke at openjdk.java.net
Wed Oct 21 12:57:14 UTC 2020


On Wed, 21 Oct 2020 12:40:04 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Shenandoah has ShenandoahGCStateResetter to reset gc state for verifier to avoid triggering barriers inadvertently, root verifier should do the same.
> 
> Also, SH::_concurrent_weak_root_in_progress flag now has implication for native barrier, ShenandoahGCStateResetter should reset this flag too.

Looks good to me. I'd change the commit msg to begin with uppercase after Shenandoah: and form an imperative statement: "Shenandoah: Reset GC state for root verifier"

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/781


More information about the shenandoah-dev mailing list