RFR: 8255070: Shenandoah: Use single thread for concurrent CLD liveness test [v2]

Zhengyu Gu zgu at openjdk.java.net
Wed Oct 21 15:42:15 UTC 2020


On Wed, 21 Oct 2020 12:49:35 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reduce duplicated code
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp line 134:
> 
>> 132:       ClassLoaderDataGraph::cld_do(clds);
>> 133:     }
>> 134:   } else if (_semaphore.try_acquire()) {
> 
> Same as above. Also, the only difference to above is cld_do() vs always_strong_cld_do(), with *lots* of identical boilerplate. Can this be refactored into a generic method that takes the final target method as argument?

Refactored and retested. Thanks for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/777


More information about the shenandoah-dev mailing list