RFR: Add 'generational' as value choice for JVM option 'ShenandoahGCMode'. [v3]

[Bernd Mathiske]

On Mon, 26 Oct 2020 21:43:52 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Bernd Mathiske has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Add 'generational' as value choice for JVM option 'ShenandoahGCMode'.
>
> src/hotspot/share/gc/shenandoah/mode/shenandoahMode.hpp line 28:
> 
>> 26: #define SHARE_GC_SHENANDOAH_MODE_SHENANDOAHMODE_HPP
>> 27: 
>> 28: #include "runtime/java.hpp"
> 
> This include looks unused.

Moved to "shenandoahGenerationalMode.cpp".

> src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2020, Red Hat, Inc. All rights reserved.
> 
> I believe "Copyright (c) 2020 ..." would be correct there.

Fixed.

> src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.cpp line 32:
> 
>> 30: #include "gc/shenandoah/heuristics/shenandoahStaticHeuristics.hpp"
>> 31: #include "gc/shenandoah/mode/shenandoahGenerationalMode.hpp"
>> 32: #include "logging/log.hpp"
> 
> Those includes for logging/* look unused. Probably leftovers?

Removed.

> src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, Red Hat, Inc. All rights reserved.
> 
> Same as above. 2020 is the year ;-)

Fixed.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/4