RFR: 8254315: Shenandoah: Concurrent weak reference processing [v12]

Tue Oct 27 14:59:24 UTC 2020

On Tue, 27 Oct 2020 14:54:41 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahMarkBitMap.inline.hpp line 64:
>> 
>>> 62: }
>>> 63: 
>>> 64: inline bool ShenandoahMarkBitMap::mark_final(HeapWord* heap_addr, bool& marked_first) {
>> 
>> It looks to me that `marked_first` is always the same as the return value? If so, can we drop that out-argument?
>
> Yes, that is true for mark_final(), but not for mark_strong(). I am changing it as you suggested.

No wait, maybe that's fine then. Let me think about it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/505