RFR: 8254315: Shenandoah: Concurrent weak reference processing [v12]

Aleksey Shipilev shade at openjdk.java.net
Tue Oct 27 15:21:24 UTC 2020


On Tue, 27 Oct 2020 10:51:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename native argument to maybe_narrow_oop for more clarity
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp line 996:
> 
>> 994:       break;
>> 995:     default:
>> 996:       ShouldNotReachHere();
> 
> I expect some compilers to complain here about the uninitialized `name`, please add `name = NULL;` before the `ShouldNotReachHere()`?

Ditto for `calladdr`, now that I looking at this block again. Maybe just initialize them at declaration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/505


More information about the shenandoah-dev mailing list