RFR: 8255457: Shenandoah: cleanup ShenandoahMarkTask [v2]

[Aleksey Shipilev]

On Tue, 27 Oct 2020 15:21:53 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp line 213:
> 
>> 211:   inline bool is_not_chunked() const { return decode_not_chunked(_obj); }
>> 212: 
>> 213:   DEBUG_ONLY(bool is_valid() const;) // Tasks to be pushed/popped must be valid.
> 
> That looks weird. I guess I prefer the previous notation, but it's your call.

Actually, the previous version looks weird (and CLion highlights it): `DEBUG_ONLY` is a macro that removes all contents, so `;` is left dangling in release mode.

> src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp line 167:
> 
>> 165: 
>> 166:   inline uintptr_t encode_oop(oop obj) const {
>> 167:     return ((uintptr_t) (void *) obj) << oop_shift;
> 
> Looks like an extra space sneaked in here. Or was that intentional?

Not intentional, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/883