RFR: 8254315: Shenandoah: Concurrent weak reference processing [v12]

Roman Kennke rkennke at openjdk.java.net
Wed Oct 28 14:41:53 UTC 2020


On Tue, 27 Oct 2020 11:06:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename native argument to maybe_narrow_oop for more clarity
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 404:
> 
>> 402:   assert(ctx->is_complete(), "sanity");
>> 403: 
>> 404:   const ShenandoahMarkBitMap* mark_bit_map = ctx->mark_bit_map();
> 
> Why `const`? Not necessarily wrong, but inconsistent with the rest of the method.

mark_bit_map() only returns a const now, and I think that's better: *if* we are to expose the bitmap, then better make it read-only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/505


More information about the shenandoah-dev mailing list