RFR: 8243208: Clean up JVMFlag implementation [v3]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Sep 9 14:20:02 UTC 2020
On Wed, 9 Sep 2020 14:16:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed JVMFlag::is_writeable()
>
> Marked as reviewed by coleenp (Reviewer).
Looks good. I had a couple of minor comments.
> In JDK-8081833, I plan to use templates to replaces the nearly identical code in
> jvmFlagRangeList.cpp/jvmFlagConstraintList.cpp, and these macros should go away.
Good!
-------------
PR: https://git.openjdk.java.net/jdk/pull/82
More information about the shenandoah-dev
mailing list