RFR: 8243208: Clean up JVMFlag implementation [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Sep 9 19:56:20 UTC 2020


On Wed, 9 Sep 2020 19:38:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/flags/jvmFlag.hpp line 36:
>> 
>>> 34: typedef const char* (*RangeStrFunc)(void);
>>> 35:
>>> 36: struct JVMFlag {
>> 
>> I'm still getting used to git diffs, but can you change this from struct to class?  Because it looks like it does have
>> private and public sections.
>
> I want to limit the changes in this PR, so I plan to do this in a future RFE, probably
> [JDK-8081833](https://bugs.openjdk.java.net/browse/JDK-8081833). I'll also change all the fields to private, and add
> accessor methods to them. And also add proper iterators for the flags (instead of walking JVMFlag::flags[] directly).

Ok that would be fine as a further change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/82


More information about the shenandoah-dev mailing list