RFR: 8243208: Clean up JVMFlag implementation [v5]

[David Holmes]

On Wed, 9 Sep 2020 21:23:32 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The initial commit [d85cbd6](https://github.com/openjdk/jdk/commit/d85cbd638f5b87c80eee9a92d10e1ac19d9bb2f8) is the
>> same patch as
>> [8243208-cleanup-jvmflag-impl.v02](https://cr.openjdk.java.net/~iklam/jdk16/8243208-cleanup-jvmflag-impl.v02/)
>> published in
>> [hotspot-dev at openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-September/042863.html).  The
>> rest of the review will continue on GitHub. I will add new commits to respond to comments to the above e-mail.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback by Gerard (hotspot-dev/2020-September/043019.html)

Marked as reviewed by dholmes (Reviewer).

src/hotspot/share/runtime/flags/jvmFlag.cpp line 714:

> 712:
> 713: // We want flagTable[] to be completely initialized at C++ compilation time, which requires
> 714: // that all arguments passed to JVMFlag() constructors to be constexpr. The following line

line 714: s/to be/be/

src/hotspot/share/runtime/flags/jvmFlag.cpp line 715:

> 713: // We want flagTable[] to be completely initialized at C++ compilation time, which requires
> 714: // that all arguments passed to JVMFlag() constructors to be constexpr. The following line
> 715: // checks for this this -- if any non-constexpr arguments are passed, the C++ compiler will

typo: this this

src/hotspot/share/runtime/flags/jvmFlagLookup.hpp line 32:

> 30:
> 31: // This is a hashtable that maps from (const char*) to (JVMFlag*) to speed up
> 32: // the processing of JVM command-line argument at runtime.

s/argument/arguments/

src/hotspot/share/runtime/flags/jvmFlagLookup.hpp line 46:

> 44:     size_t len = 0;
> 45:     while (*s != 0) {
> 46:       len ++;

Unwanted space before ++

-------------

PR: https://git.openjdk.java.net/jdk/pull/82