Integrated: 8243208: Clean up JVMFlag implementation

[David Holmes]

Hi Goetz,

On 14/09/2020 4:13 pm, Lindenmaier, Goetz wrote:
> Hi,
> 
> Since this change was pushed, we see the following build error on Windows:
> .../src/hotspot/share/runtime/flags/jvmFlagLookup.cpp(54): error C2220: warning treated as error - no 'object' file generated
> .../src/hotspot/share/runtime/flags/jvmFlagLookup.cpp(54): warning C4307: '*': integral constant overflow
> 
> We are compiling with Microsoft Visual Studio 2017.
> 
> (Is it the right way to write a mail to bring this up, or
> should I comment the PullRequest or the like?)

You can write a mail or just file a bug. :)

Is this 32-bit Windows? We have not seen any issue in our 64-bit builds.

Thanks,
David


> Best regards,
>    Goetz
> 
>> -----Original Message-----
>> From: hotspot-dev <hotspot-dev-retn at openjdk.java.net> On Behalf Of Ioi
>> Lam
>> Sent: Friday, September 11, 2020 6:08 AM
>> To: hotspot-dev at openjdk.java.net; shenandoah-dev at openjdk.java.net
>> Subject: Integrated: 8243208: Clean up JVMFlag implementation
>>
>> On Tue, 8 Sep 2020 18:33:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>>
>>> The initial commit
>> [d85cbd6](https://github.com/openjdk/jdk/commit/d85cbd638f5b87c80eee
>> 9a92d10e1ac19d9bb2f8) is the
>>> same patch as
>>> [8243208-cleanup-jvmflag-
>> impl.v02](https://cr.openjdk.java.net/~iklam/jdk16/8243208-cleanup-
>> jvmflag-impl.v02/)
>>> published in
>>> [hotspot-
>> dev at openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-
>> dev/2020-September/042863.html).  The
>>> rest of the review will continue on GitHub. I will add new commits to
>> respond to comments to the above e-mail.
>>
>> This pull request has now been integrated.
>>
>> Changeset: 5144190e
>> Author:    Ioi Lam <iklam at openjdk.org>
>> URL:       https://git.openjdk.java.net/jdk/commit/5144190e
>> Stats:     2127 lines in 45 files changed: 533 ins; 755 del; 839 mod
>>
>> 8243208: Clean up JVMFlag implementation
>>
>> Reviewed-by: dholmes, coleenp, gziemski
>>
>> -------------
>>
>> PR: https://git.openjdk.java.net/jdk/pull/82