RFR: 8243208: Clean up JVMFlag implementation [v6]

Aleksey Shipilev shade at openjdk.java.net
Mon Sep 14 07:41:57 UTC 2020


On Mon, 14 Sep 2020 07:28:07 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Marked as reviewed by gziemski (Committer).
>
> Maybe it's complaining about this "*" in jvmFlagLookup.hpp? How about this:
> 
>   static constexpr unsigned int hash_code(const char* s, size_t len) {
>     unsigned int h = 0;
>     while (len -- > 0) {
> -     h = 31*h + (unsigned int) *s;
> +     h = ((unsigned int)31)*h + (unsigned int) *s;
>       s++;
>     }
>     return h;

Seeing Windows build failures on some of my Windows build nodes as well. Filed
https://bugs.openjdk.java.net/browse/JDK-8253089, please discuss there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/82


More information about the shenandoah-dev mailing list