RFR: 8251358: Clean up Access configuration after Shenandoah barrier change

Erik Österlund eosterlund at openjdk.java.net
Tue Sep 15 09:40:51 UTC 2020


On Mon, 14 Sep 2020 05:16:11 GMT, Aditya Mandaleeka <adityam at openjdk.org> wrote:

> This change removes a bunch of code that is no longer necessary after the Shenandoah barrier changes, including the
> `SUPPORT` macros in barrierSetConfig.hpp and code using them. `Access::resolve` and associated code have also been
> removed, and callers have been modified.  Testing done:
> tier1
> hotspot_gc_shenandoah

Thanks for fixing this. It's nice to see build-time decorators go. Naturally, when removing the resolve() function, we
can also remove a bunch of "_raw" functions in the runtime. Like there is no longer a need to distinguish between
field_addr and field_addr_raw. Or between base and base_raw. They were all introduced so that one of them could apply
the resolve barrier. The same goes for mark vs mark_raw and the other related mark accessor functions on oopDesc. I
think we want to get rid of that too, right?

-------------

Changes requested by eosterlund (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/146


More information about the shenandoah-dev mailing list