RFR: 8253271: vm_version_x86.hpp should not include globals_extension.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Sep 17 17:57:21 UTC 2020


> [vm_version_x86.hpp](https://github.com/openjdk/jdk/blob/b87a1599674b8a73f489330decf051d1be9e9fba/src/hotspot/cpu/x86/vm_version_x86.hpp#L30)
> is a popular header file (which in itself is a problem but I'll fix that in a separate RFE) and it unnecessarily
> includes globals_extension.hpp.  Removing this dependency reduces the number of cpp files that include
> globals_extension.hpp from 814 to 67.
> I need to fix cpp files that use macros like FLAG_SET_ERGO but forgot to include  globals_extension.hpp.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  added more missing includes found by CI testing

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/217/files
  - new: https://git.openjdk.java.net/jdk/pull/217/files/a5a2f03e..ce1508af

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=217&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=217&range=00-01

  Stats: 19 lines in 17 files changed: 17 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/217.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/217/head:pull/217

PR: https://git.openjdk.java.net/jdk/pull/217


More information about the shenandoah-dev mailing list