RFR: 8253271: vm_version_x86.hpp should not include globals_extension.hpp [v3]
Ioi Lam
iklam at openjdk.java.net
Thu Sep 17 21:35:26 UTC 2020
> [vm_version_x86.hpp](https://github.com/openjdk/jdk/blob/b87a1599674b8a73f489330decf051d1be9e9fba/src/hotspot/cpu/x86/vm_version_x86.hpp#L30)
> is a popular header file (which in itself is a problem but I'll fix that in a separate RFE) and it unnecessarily
> includes globals_extension.hpp. Removing this dependency reduces the number of cpp files that include
> globals_extension.hpp from 814 to 67.
> I need to fix cpp files that use macros like FLAG_SET_ERGO but forgot to include globals_extension.hpp.
Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last
revision:
- Merge branch 'master' into 8253271-remove-globals-extensions-from-vm-version-x86-hpp
- added more missing includes found by CI testing
- 8253271: vm_version_x86.hpp should not include globals_extension.hpp
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/217/files
- new: https://git.openjdk.java.net/jdk/pull/217/files/ce1508af..28e894f3
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=217&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=217&range=01-02
Stats: 288 lines in 32 files changed: 131 ins; 29 del; 128 mod
Patch: https://git.openjdk.java.net/jdk/pull/217.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/217/head:pull/217
PR: https://git.openjdk.java.net/jdk/pull/217
More information about the shenandoah-dev
mailing list