RFR: 8251358: Clean up Access configuration after Shenandoah barrier change [v2]

Aditya Mandaleeka adityam at openjdk.java.net
Thu Sep 24 07:02:31 UTC 2020


On Thu, 24 Sep 2020 06:41:06 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> Speaking of JDK-8199735, `cas_set_mark_raw` is also unnecessary now?
>
>> Speaking of JDK-8199735, `cas_set_mark_raw` is also unnecessary now?
> 
> Yes, good catch. I found 2 more mark word accessors that I commented on.

Thanks @shipilev and @fisk . I had left `cas_set_mark_raw` alone since there's a caller that specifies
`memory_order_release` and I didn't want to change any behavior with the cleanup:
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp#L242

That said, I haven't looked into how necessary that is; perhaps it's okay to change it to relaxed order.

@fisk Thanks for taking another look. I don't see the new comments you added yet. Have you submitted them?

I'll follow up on this PR tomorrow since it's quite late here ��

-------------

PR: https://git.openjdk.java.net/jdk/pull/146


More information about the shenandoah-dev mailing list