RFR: 8265103: Remove unnecessary inclusion of oopMap.hpp

Stefan Karlsson stefank at openjdk.java.net
Tue Apr 13 07:17:59 UTC 2021


On Tue, 13 Apr 2021 07:09:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/c1/c1_LinearScan.hpp line 34:
>> 
>>> 32: #include "c1/c1_LIR.hpp"
>>> 33: #include "c1/c1_LIRGenerator.hpp"
>>> 34: #include "compiler/oopMap.hpp"
>> 
>> The description states:
>>> There are only 4 header files that include oopMap.hpp. All of these can be replaced for forward declarations.
>> 
>> But this had to be added. Did you check how many files include c1_LinearScan.hpp?
>
>> The description states:
>> 
>> > There are only 4 header files that include oopMap.hpp. All of these can be replaced for forward declarations.
>> 
>> But this had to be added. Did you check how many files include c1_LinearScan.hpp?
> 
> c1_LinearScan.hpp is included in only 6 .o files.

Great!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3446


More information about the shenandoah-dev mailing list