RFR: Mixed evacuation [v2]

[Kelvin Nilsen]

On Mon, 12 Apr 2021 19:43:54 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Chasing bug during prepare_for_old_collection
>>   
>>   One bug fix, a few cosmetic improvements, a change in loop structure to possibly avoid a gcc
>>   optimization error.
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 440:
> 
>> 438:   return (_generation->generation_mode() == GLOBAL)
>> 439:     || (_generation->generation_mode() == YOUNG && region->affiliation() == YOUNG_GENERATION)
>> 440:     || (_generation->generation_mode() == OLD && region->affiliation() == OLD_GENERATION);
> 
> I wouldn't change indentation here, or if it needs changing, then line up the || with the _generation above. Iow, shift it 4 spaces to the right instead of 2 spaces to the left.

I think I've fixed this now.  Auto-indent of my editor got carried away and I apparently lost track of original spacing.

> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 454:
> 
>> 452:   for (size_t i = 0; i < num_regions; i++) {
>> 453:     ShenandoahHeapRegion* region = heap->get_region(i);
>> 454:     if (!in_generation(region))
> 
> Please always use { and } in if (and else) constructs.

Ok.  Fixed.  (This code moved to shenadoahOldHeuristics.cpp)

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/29