RFR: Mixed evacuation [v6]
Kelvin Nilsen
kdnilsen at openjdk.java.net
Wed Apr 21 21:02:49 UTC 2021
On Wed, 21 Apr 2021 10:45:22 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Change definition of CollectionThresholdGarbagePercent
>>
>> This is now defined to equal ShenandoahGarbageThreshold, which seems to have
>> a default value of 25. The effect on running workloads is to choose more
>> regions for the collection set than was observed with the previous
>> configuration.
>>
>> Also addressed several improvements in white space and comments.
>>
>> The code now runs tier1 and hotspot_gc_shenandoah without regressions. It
>> also succsessfully runs an Extremem stress test up until the point of
>> failure due to triggering of full GC (after 113 completed GC passes, including
>> two old-gen GC passes).
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 99:
>
>> 97: byte_size_in_proper_unit(min_garbage), proper_unit_for_byte_size(min_garbage));
>> 98:
>> 99:
>
> We have a lone newline here.
Fixed in next commit
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveOldHeuristics.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2019, 2021, Red Hat, Inc. All rights reserved.
>
> Please, only put first and last year in copyright notice (from-to).
Fixed in next commit.
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveOldHeuristics.hpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2019, 2021, Red Hat, Inc. All rights reserved.
>
> Same as above.
Fixed in next commit.
-------------
PR: https://git.openjdk.java.net/shenandoah/pull/29
More information about the shenandoah-dev
mailing list