RFR: Milestone 1 [v3]

[Aditya Mandaleeka]

On Thu, 21 Jan 2021 21:09:43 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove trailing white space
>
> Very nice! Only one question regarding what looks like a rogue include. Also, maybe the testprogram can be readily included as first jtreg test that exercises genshen when running make test TEST=hotspot_gc_shenandoah (even when it probably doesn't test anything except that it doesn't crash)?

This looks good to me. I like the idea to include the test into hs_gc_shen as the first "real" jtreg test for genshen. In time, perhaps tier1 genshen tests (like "does card marking crash") should be in the Shenandoah tier1 tests, but for now I'm fine with it where you put it.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/13