RFR: 8261106: Reduce inclusion of jniHandles.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Feb 4 17:20:00 UTC 2021


> niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.
> 
> - ci/ciBaseObject.hpp
> - ci/ciMetadata.hpp
> - ci/ciObject.hpp
> - classfile/moduleEntry.hpp
> - gc/shared/gcVMOperations.hpp
> - jvmci/jvmciJavaClasses.hpp
> - runtime/thread.hpp
> - services/threadService.hpp
> 
> Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.
> 
> Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.
> 
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8261106-reduce-jniHandles-hpp
 - 8261106: Reduce inclusion of jniHandles.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2393/files
  - new: https://git.openjdk.java.net/jdk/pull/2393/files/e7f2d097..6e77fbea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2393&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2393&range=00-01

  Stats: 7440 lines in 439 files changed: 4576 ins; 1518 del; 1346 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2393.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2393/head:pull/2393

PR: https://git.openjdk.java.net/jdk/pull/2393


More information about the shenandoah-dev mailing list