RFR: 8261125: Move VM_Operation to vmOperation.hpp [v4]

Ioi Lam iklam at openjdk.java.net
Wed Feb 17 05:32:05 UTC 2021


> vmOperations.hpp declares the VM_Operation class, as well as a hodge podge of subclasses such as VM_ForceSafepoint, VM_DeoptimizeFrame.
> 
> Out of the 1000 hotspot .o files, about 680 include vmOperations.hpp (mostly transitively). In most cases, they just need to use the VM_Operation class.
> 
> So we should move VM_Operation to its own header: vmOperation.hpp (no "s").
> 
> After the refactoring, vmOperations.hpp is included only 64 times. The inclusion count of threadSMR.hpp is also reduced from 687 to 99. HotSpot build time is improved by about 0.4%.
> 
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into 8261125-move-VM_Operation-to-vmOperation.hpp
 - Merge branch 'master' into 8261125-move-VM_Operation-to-vmOperation.hpp
 - interfaceSupport.inline.hpp needs VM_Exit from vmOperations.hpp for JVM_LEAF macro
 - 8261125: Move VM_Operation to vmOperation.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2398/files
  - new: https://git.openjdk.java.net/jdk/pull/2398/files/bab79154..5b8f1b4b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2398&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2398&range=02-03

  Stats: 8513 lines in 340 files changed: 4350 ins; 2305 del; 1858 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2398.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2398/head:pull/2398

PR: https://git.openjdk.java.net/jdk/pull/2398


More information about the shenandoah-dev mailing list