Integrated: Fix Zero builds

Aleksey Shipilev shade at openjdk.java.net
Thu Feb 18 06:54:04 UTC 2021


On Wed, 17 Feb 2021 19:22:02 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Zero builds currently fail with:
> 
> In file included from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp:28,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.cpp:26:
> 
> 
>    45 |       log_info(gc)("Heuristics ergonomically sets -XX:+" #name);            \
>       |                ^~
> 
>    39 |   SHENANDOAH_ERGO_ENABLE_FLAG(ExplicitGCInvokesConcurrent);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/runtime/stackWatermarkSet.hpp:29,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/runtime/thread.hpp:42,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/runtime/safepoint.hpp:30,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shared/collectedHeap.hpp:35,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp:30,
>                  from /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp:28,
>    ... (rest of output omitted)
> 
> This is because we are missing the "log" includes (look at `shenandoahSATBMode.cpp` for comparison), which are not transitively available with Zero builds.
> 
> Additional testing: 
>  - [x] Linux x86_64 Zero build (now passes)

This pull request has now been integrated.

Changeset: 179c167a
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/shenandoah/commit/179c167a
Stats:     3 lines in 1 file changed: 3 ins; 0 del; 0 mod

Fix Zero builds

Reviewed-by: rkennke

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/18


More information about the shenandoah-dev mailing list