RFR: 8261868: Reduce inclusion of metaspace.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Feb 25 04:36:40 UTC 2021


On Fri, 19 Feb 2021 06:08:09 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> One more file you may consider updating is share/memory/classLoaderMetaspace.cpp.
> It now depends on metaspaceUtils.hpp but it includes it transitively via metaspaceTracer.hpp.
> The include of metaspace.hpp is not needed because classLoaderMetaspace.hpp includes it.
> 
> Other changes seem good.

I added metaspaceUtils.hpp to classLoaderMetaspace.cpp. I kept metaspace.hpp in there -- our convention is to always explicitly include a header file if we use its contents, even if this header file might be transitively included by other headers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2599


More information about the shenandoah-dev mailing list