RFR: 8255019: Shenandoah: Split STW and concurrent mark into separate classes [v24]

[Aleksey Shipilev]

On Mon, 11 Jan 2021 13:49:16 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 161:
>> 
>>> 159:     // threads, and performance-wise it doesn't really matter. Adds about 1ms to
>>> 160:     // full-gc.
>>> 161:     {
>> 
>> This seems to revert JDK-8258490?
>
> No. After splitting, full-gc never gets here.

Why the comment that mentions mark-compact and full-gc then?

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 168:
>> 
>>> 166:       while (satb_mq_set.apply_closure_to_completed_buffer(&cl));
>>> 167:       bool do_nmethods = heap->unload_classes() && !ShenandoahConcurrentRoots::can_do_concurrent_class_unloading();
>>> 168:       assert(!heap->has_forwarded_objects(), "Not expected");
>> 
>> Do you need to move this assert?
>
> No, fixed.

Note it still removes the new line.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1009