RFR: 8255019: Shenandoah: Split STW and concurrent mark into separate classes [v24]

Zhengyu Gu zgu at openjdk.java.net
Mon Jan 11 18:41:06 UTC 2021


On Mon, 11 Jan 2021 17:42:02 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp line 58:
>> 
>>> 56:   // TODO: where to put them
>>> 57:   static void update_roots(ShenandoahPhaseTimings::Phase root_phase);
>>> 58:   static void update_thread_roots(ShenandoahPhaseTimings::Phase root_phase);
>> 
>> Sounds like these better to be shared in `ShenandoahMark`?
>
> This is still unanswered.

They are not really marking functions, they do not belong to there neither ... I left them there, and moved them to ShenandoahGC in next PR (isolate GCs). Okay?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1009


More information about the shenandoah-dev mailing list