RFR: 8259580: Shenandoah: uninitialized label in VerifyThreadGCState

Roman Kennke rkennke at openjdk.java.net
Mon Jan 11 20:57:06 UTC 2021


On Mon, 11 Jan 2021 19:02:55 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> "label" is passed, but never hooked into the field. So instead of reporting a GC bug, Verifier would probably crash itself trying to read garbage memory.

src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 606:

> 604: private:
> 605:   const char* const _label;
> 606:          char const _expected;

Why can't _expected not be const char* const too? Are we really messing with the string on the way?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2033


More information about the shenandoah-dev mailing list