RFR: Scan remembered [v2]

Kelvin Nilsen github.com+51720475+kdnilsen at openjdk.java.net
Thu Jan 14 05:12:19 UTC 2021


On Wed, 13 Jan 2021 13:49:41 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improvements requested during initial review
>>   
>>   These changes are cosmetic and/or related to comments.
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 323:
> 
>> 321:     // Increment age in young copies.
>> 322:     if (target_gen == YOUNG_GENERATION) {
>> 323:       copy_val->incr_age();
> 
> I am not sure incr_age() work with concurrent version. e.g. if the object has displaced mark and two threads try to evacuate the object, both will increase age on displaced mark word.

We did discover the need to deal with displaced mark words and a subsequent commit replaces the call to incr_age() with a call to a newly introduced incrase_object_age() function which includes special handling for displaced mark words.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/12


More information about the shenandoah-dev mailing list