RFR: Scan remembered [v2]

Kelvin Nilsen github.com+51720475+kdnilsen at openjdk.java.net
Thu Jan 14 05:24:24 UTC 2021


On Wed, 13 Jan 2021 12:10:07 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improvements requested during initial review
>>   
>>   These changes are cosmetic and/or related to comments.
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 76:
> 
>> 74: #include "gc/shenandoah/mode/shenandoahPassiveMode.hpp"
>> 75: #include "gc/shenandoah/mode/shenandoahSATBMode.hpp"
>> 76: #include "gc/shenandoah/shenandoahScanRemembered.inline.hpp"
> 
> I noticed now, that you also include shenandoahScanRemembered.hpp above. You only need to include the .inline.hpp, and bonus points for keeping it in alphabethical order... ;-)

Thanks.  This fix will be reflected in my next push.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/12


More information about the shenandoah-dev mailing list