RFR: Scan remembered [v2]

[Kelvin Nilsen]

On Mon, 11 Jan 2021 10:42:55 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improvements requested during initial review
>>   
>>   These changes are cosmetic and/or related to comments.
>
> src/hotspot/share/gc/shenandoah/shenandoahBufferWithSATBRememberedSet.hpp line 61:
> 
>> 59: // existing SATB pre-write barrier to maintain remembered set information rather than using unconditional direct card marking in
>> 60: // a post-write barrier.
>> 61: class ShenandoahBufferWithSATBRememberedSet: public CHeapObj<mtGC> {
> 
> It's also lacking the usual #ifndef - #define - #endif sequence that is needed by headers.

This file has been removed from the pull request.

> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 787:
> 
>> 785:   // What card number corresponds to old-gen heap addresss p.  (If p
>> 786:   // does not refer to old-gen memory, the returned value is undefined.)
>> 787:   uint32_t cardNoForAddr(HeapWord *p);
> 
> Should be named card_no_for_addr(HeapWord* p) to match style of most other Hotspot code.

Removed.

> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.inline.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) Amazon.com, Inc. or its affiliates.  All rights reserved.
> 
> Missing copyright year.

We've asked around inside Amazon.  We're good to add in the copyright dates.  So next commit will include these.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/12