RFR: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019

Zhengyu Gu zgu at openjdk.java.net
Tue Jan 19 13:13:37 UTC 2021


On Tue, 19 Jan 2021 10:27:26 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I believe `ShenandoahSTWMark` misses the TQ stats reset after the takeover from concurrent cycle. See the stack trace and events info in the bug.
> 
> Additional testing:
>  - [x] Linux x86_64, failing tests now pass
>  - [x] Linux x86_64 `hotspot_gc_shenandoah`
>  - [x]  Linux x86_64 `tier1` with Shenandoah

Thanks for catching this. Looks good.

Concurrent mark resets qstats in ShenandoahConcurrentMark::mark_stw_roots(), so it should be fine.

-------------

Marked as reviewed by zgu (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2141


More information about the shenandoah-dev mailing list