RFR: 8260106: Shenandoah: simplify maybe_update_with_forwarded and related code

Zhengyu Gu zgu at openjdk.java.net
Wed Jan 20 19:13:51 UTC 2021


On Wed, 20 Jan 2021 15:06:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> We have a block in `ShenandoahHeap::maybe_update_with_forwarded` that is irrelevant after JDK-8231086. Additionally, "resolve and update" paths are really only used by STW GCs, and thus do not require atomic updates. This leads to considerable simplifications in the code, and improves performance on the common paths (especially in fastdebug builds that drop many irrelevant asserts).
> 
> Additional testing:
>  - [x] `hotspot_gc_shenandoah`
>  - [ ] `tier1` with Shenandoah
>  - [ ] `tier2` with Shenandoah

Looks good. 

Please update copyright years of  shenandoahHeap.inline.hpp and shenandoahOopClosures.hpp

-------------

Marked as reviewed by zgu (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2166


More information about the shenandoah-dev mailing list