RFR: 8260106: Shenandoah: simplify maybe_update_with_forwarded and related code [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Jan 21 08:06:10 UTC 2021


> We have a block in `ShenandoahHeap::maybe_update_with_forwarded` that is irrelevant after JDK-8231086. Additionally, "resolve and update" paths are really only used by STW GCs, and thus do not require atomic updates. This leads to considerable simplifications in the code, and improves performance on the common paths (especially in fastdebug builds that drop many irrelevant asserts).
> 
> Additional testing:
>  - [x] `hotspot_gc_shenandoah`
>  - [ ] `tier1` with Shenandoah
>  - [ ] `tier2` with Shenandoah

Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:

 - Rename maybe to atomic
 - Touch up comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2166/files
  - new: https://git.openjdk.java.net/jdk/pull/2166/files/88c15df1..764ec461

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2166&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2166&range=00-01

  Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2166.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2166/head:pull/2166

PR: https://git.openjdk.java.net/jdk/pull/2166


More information about the shenandoah-dev mailing list