RFR: 8259954: gc/shenandoah/mxbeans tests fail with -Xcomp

Eric Liu github.com+10482586+therealeliu at openjdk.java.net
Thu Jan 21 10:15:55 UTC 2021


On Thu, 21 Jan 2021 10:00:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> test/hotspot/jtreg/gc/shenandoah/mxbeans/TestChurnNotifications.java line 167:
>> 
>>> 165:             Thread.sleep(1000);
>>> 166:         }
>>> 167:         Thread.sleep(5000);
>> 
>> I was wandering if it's necessary to handle the timeout by the code itself instead of delegating to jtreg? In the worst case, that's a really long time about 960000ms.
>
> Yeah, I was wondering about the same when doing that chunk, but then argued to myself that timeout might be as well handled by jtreg. Mostly because in many cases JTREG_TIMEOUT_FACTOR is passed to control the machine-dependent behavior: slower/overloaded machines get larger timeout factors configured. Hardcoding the timeouts in the test would deprive us of this "feature".

Thanks, that's make sense to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2179


More information about the shenandoah-dev mailing list