RFR: 8260106: Shenandoah: simplify maybe_update_with_forwarded and related code [v3]

[Roman Kennke]

On Fri, 22 Jan 2021 12:16:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> We have a block in `ShenandoahHeap::maybe_update_with_forwarded` that is irrelevant after JDK-8231086. Additionally, "resolve and update" paths are really only used by STW GCs, and thus do not require atomic updates. This leads to considerable simplifications in the code, and improves performance on the common paths (especially in fastdebug builds that drop many irrelevant asserts).
>> 
>> Additional testing:
>>  - [x] `hotspot_gc_shenandoah`
>>  - [x] `tier1` with Shenandoah
>>  - [x] `tier2` with Shenandoah
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Simplify further after RESOLVE removal
>  - Merge branch 'master' into JDK-8260106-shenandoah-simplify-updates
>  - Rename maybe to atomic
>  - Touch up comments
>  - 8260106: Shenandoah: simplify maybe_update_with_forwarded and related code

Looks good to me! Thanks!

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2166