RFR: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code

Aleksey Shipilev shade at openjdk.java.net
Wed Jan 27 15:17:45 UTC 2021


On Wed, 27 Jan 2021 15:00:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_32.cpp line 3683:
>> 
>>> 3681:       __ movflt(Address(rsp, xmm_size * 1), xmm1);
>>> 3682:       __ movflt(Address(rsp, xmm_size * 0), xmm0);
>>> 3683:     }
>> 
>> I am not sure that we should sneak in this shared-code change with what is otherwise a Shenandoah-change.
>
> This is nmethod barrier handling part, and on x86_32, Shenandoah is the only user of this code. I can split it out, but it would still be Shenandoah-specific.

(...and I don't like to split it, because both hunks are needed to pass testing)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1172


More information about the shenandoah-dev mailing list