RFR: 8260586: Shenandoah: simplify "Concurrent Weak References" logging [v2]
Zhengyu Gu
zgu at openjdk.java.net
Thu Jan 28 17:29:44 UTC 2021
On Thu, 28 Jan 2021 17:05:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Concurrent Weak References always does parallel worker operation. Therefore "Process" counter is redundant, and we might as well make the root counter the per-worker one. This simplifies GC logging.
>>
>> Old log:
>>
>> [95.220s][info][gc,stats] Concurrent Weak References 1709 us
>> [95.220s][info][gc,stats] Process 1588 us, parallelism: 1.30x
>> [95.220s][info][gc,stats] CWRF: <total> 2056 us
>> [95.220s][info][gc,stats] CWRF: Weak References 2056 us, workers (us): 454, 1450, 2, 145, 4, 1, 0, 0,
>>
>> New log:
>>
>> [39.583s][info][gc,stats] Concurrent Weak References 651 us, parallelism: 1.52x
>> [39.583s][info][gc,stats] CWRF: <total> 986 us
>> [39.583s][info][gc,stats] CWRF: Weak References 986 us, workers (us): 183, 29, 145, 627, 1, 0, 0, 0,
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8260586-sh-log-cwr
> - 8260586: Shenandoah: simplify "Concurrent Weak References" logging
Looks good.
-------------
Marked as reviewed by zgu (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2288
More information about the shenandoah-dev
mailing list