RFR: 8260471: Change SystemDictionary::X_klass calls to vmClasses::X_klass

Ioi Lam iklam at openjdk.java.net
Thu Jan 28 21:07:57 UTC 2021


On Thu, 28 Jan 2021 21:00:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This is the second step of https://github.com/openjdk/jdk/pull/2246 (8260467: Move well-known classes from systemDictionary.hpp to vmClasses.hpp). These are mostly boiler-plate changes done by scripts.
> 
> [1]  Change calls like 
> 
> SystemDictionary::Object_klass()
> SystemDictionary::Throwable_klass_is_loaded()
> SystemDictionary::box_klass_type()
> 
> to 
> 
> vmClasses::Object_klass()
> vmClasses::Throwable_klass_is_loaded()
> vmClasses::box_klass_type()
> 
> [2] Remove unnecessary inclusion of systemDictionary.hpp (replace with vmClasses.hpp if necessary). In some cases, I have to add signature.hpp to some files, which only indirectly included signature.hpp through systemDictionary.hpp.
> 
> [3] In the previous PR, I incorrectly used the enum name `VMClassID`. This PR changes it to `vmClassID` to match the existing use of `vmSymbolID` and `vmIntrinsicID`.
> 
> Due to the refactoring of these two PRs, the number of HotSpot .o files that include systemDictionary.hpp decreases from 491 to 91. HotSpot build time is reduced by about 2%
> 
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

To make reviewing the 185 files a little easier, I haven't changed the copyright dates yet. I'll do that before the final integration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2301


More information about the shenandoah-dev mailing list