[aarch64-port-dev ] RFR/RFC: Shenandoah integration 2021-03-11

[Andrew Hughes]

On 17:19 Thu 11 Mar     , Aleksey Shipilev wrote:
> Hi,
> 
> I would like to integrate the regular update of Shenandoah 8u to our
> integration repository, aarch64-port/jdk8u-shenandoah. It comes with a few
> large features:
>  - Self-fixing load barriers
>  - JFR events support
>  - ShenadnoahSoftMaxHeapSize support
>  - Other cleanups and bugfixes
> 
> Webrev:
>   https://cr.openjdk.java.net/~shade/shenandoah/merges/aarch64-port-8u-20210311/webrev.01/
> 
> There is no merge changeset, as shenandoah/jdk8 forest is clean downstream
> of integration repository. I am tagging the whole thing as
> aarch64-shenandoah-jdk8u292-b05-shenandoah-merge-2021-03-11.

Sounds good. The webrev does suggest there are merge revisions though:

https://cr.openjdk.java.net/~shade/shenandoah/merges/aarch64-port-8u-20210311/webrev.01/

e.g. "rev 12213 : Merge"

> 
> Testing: hotspot_gc_shenandoah; it also runs pretty stably in our CIs, and
> we have no user bugreports from our 8u nightlies

Was it tested without INCLUDE_ALL_GCS defined?

My only concern is the backporting of 8202976: "Add C1 lea patching support for x86"

It looks like the changes will have no effect when Shenandoah is disabled at runtime,
though the code changes differ between using INCLUDE_ALL_GCS as well in
c1_LIRAssembler_aarch64.cpp but not in c1_LIRAssembler_x86.cpp (difficult to do
so there with the structure of the code).

At the very least, this will produce some unused variable warnings, but that is true
of JDK-8202976 in 11u too.

> 
> -- 
> Thanks,
> -Aleksey
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222