RFR: 8263427: Shenandoah: Trigger weak-LRB even when heap is stable [v5]

Aleksey Shipilev shade at openjdk.java.net
Tue Mar 16 10:57:49 UTC 2021


On Tue, 16 Mar 2021 10:52:56 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahNMethod.inline.hpp line 31:
>> 
>>> 29: #include "gc/shared/barrierSetNMethod.hpp"
>>> 30: #include "gc/shenandoah/shenandoahNMethod.hpp"
>>> 31: #include "gc/shenandoah/shenandoahClosures.inline.hpp"
>> 
>> Is this include necessary? I cannot see why.
>
> I removed the same include in shenandoahUnload.cpp because it is no longer needed there. But it's needed here because of ShenandoahEvacuateUpdateMetadataClosure. It was only reachable through the include in shenandoahUnload.cpp before.

Ah. Makes sense then.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2945


More information about the shenandoah-dev mailing list