RFR: Refix ShenandoahPurgeSATBTask

earthling-amzn github.com+71722661+earthling-amzn at openjdk.java.net
Tue Mar 23 18:23:03 UTC 2021


On Tue, 23 Mar 2021 17:45:17 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> My early fix was incomplete and incorrect.
> 
> 1) ShenandoahPurgeSATBTask needs to change thread claim token for iterating threads in parallel, this was missing in early change.
> 2) Threads::threads_do() -> Threads::possibly_parallel_threads_do() was incorrect, the later version only iterates Java and VM threads. This part of changes are reverted.
> 3) A minor change: declaring _trashed_oops as volatile as it is a shared variable.

Thanks again for setting this straight.

-------------

Marked as reviewed by earthling-amzn at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/shenandoah/pull/25


More information about the shenandoah-dev mailing list