RFR: 8267653: Remove Mutex::_safepoint_check_sometimes [v2]

[Patricio Chilano Mateo]

On Wed, 26 May 2021 01:53:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Since SR_lock is removed, this state of declaring locks as sometimes safepoint checking and not is no longer used.  JavaThreads either always or never check for safepoint, depending on the lock.  The Heap_lock was always a bit special because it's taken by a JavaThread after it exits, but the code in mutex::lock_contended already deals with this (ie doesn't safepoint check while exiting).
>> Tested with tier 2-3 and tier1 in progress.
>> Thanks to Zhengu for testing and confirming shenandoah (I built and ran shenandoah tests too).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add assert that the thread is terminated before taking Heap_lock

Looks good to me!

Thanks,
Patricio

-------------

Marked as reviewed by pchilanomate (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4184