RFR: Add an option to stream region sampling data to a file [v2]

William Kemper wkemper at openjdk.java.net
Thu Oct 7 17:11:19 UTC 2021


On Thu, 7 Oct 2021 16:10:41 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Whitespace fixes
>>  - Update copyright headers
>
> src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.cpp line 92:
> 
>> 90:     jlong last = _last_sample_millis;
>> 91:     if (current - last > ShenandoahRegionSamplingRate &&
>> 92:         Atomic::cmpxchg(&_last_sample_millis, last, current) == last) {
> 
> Neither the previous nor the new version seems to align correctly.

Fixed

> src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.hpp line 104:
> 
>> 102: 
>> 103: #endif // SHARE_GC_SHENANDOAH_SHENANDOAHHEAPREGIONCOUNTERS_HPP
>> 104: 
> 
> Bunch of unrelated new newlines.

Deleted extra lines

> src/hotspot/share/gc/shenandoah/shenandoahLogFileOutput.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2013, 2021, Red Hat, Inc. All rights reserved.
> 
> Is this a new file? Then the 2021-Amazon header should be enough. If it's derived from an existing file, then the header is ok as it is.

Both these files were derived from `logFileOutput`, which has an Oracle copyright. I've updated the copyright headers.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/82


More information about the shenandoah-dev mailing list