RFR: 8274004: Change 'nonleaf' rank name [v2]

[Coleen Phillimore]

On Fri, 8 Oct 2021 00:48:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix overlap error message printing and add a test.
>
> test/hotspot/gtest/runtime/test_mutex.cpp line 292:
> 
>> 290:   Monitor* monitor_rank_broken = new Monitor(Mutex::oopstorage-4, "monitor_rank_broken");
>> 291:   monitor_rank_broken->lock_without_safepoint_check();
>> 292:   monitor_rank_broken->unlock();
> 
> This is dead code right - the assertion failure will stop us getting here.

Yes, it is dead code.  I'll remove it and retest to make sure nothing surprising happens.

> test/hotspot/gtest/runtime/test_mutex.cpp line 302:
> 
>> 300:   Monitor* monitor_rank_broken = new Monitor(Mutex::safepoint-40, "monitor_rank_broken");
>> 301:   monitor_rank_broken->lock_without_safepoint_check();
>> 302:   monitor_rank_broken->unlock();
> 
> Ditto - dead code

removed.

> test/hotspot/gtest/runtime/test_mutex.cpp line 310:
> 
>> 308:   ThreadInVMfromNative invm(THREAD);
>> 309: 
>> 310:   Monitor* monitor_rank_broken = new Monitor(Mutex::safepoint-1, "monitor_rank_broken");
> 
> This rank is not actually broken is it - otherwise we won't get to the next line.

right.  It's not broken.  I'll rename it to 'monitor_rank_ok'.

> test/hotspot/gtest/runtime/test_mutex.cpp line 313:
> 
>> 311:   Monitor* monitor_rank_also_broken = new Monitor(monitor_rank_broken->rank()-39, "monitor_rank_also_broken");
>> 312:   monitor_rank_also_broken->lock_without_safepoint_check();
>> 313:   monitor_rank_also_broken->unlock();
> 
> Dead code

removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5845