RFR: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check

Aleksey Shipilev shade at openjdk.java.net
Mon Oct 11 10:49:10 UTC 2021


On Fri, 8 Oct 2021 13:40:51 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> JDK-8273917 lowered MultiArray_lock rank from nonleaf+2 to nonleaf, that results several Shenandoah tests failed on lock rank check.
> 
> This patch lowers ShenandoahAllocFailureGC_lock rank by 2 to maintain original order.
> 
> 
> Test:
> 
> - [x] hotspot_gc_shenandoah

Hold on a sec, I have questions...

I see `MultiArray_lock` is `safepoint`. Shouldn't this be `safepoint - 1` then? 
I think this would basically say "you can acquire any `safepoint` lock", right?
Also, does the same thing apply to `_gc_waiters_lock`?

Changing both locks to `safepoint - 1` passes `hotspot_gc_shenandoah` for me here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5865


More information about the shenandoah-dev mailing list