RFR: Remove vestigial command line options and removed unused code
Roman Kennke
rkennke at openjdk.java.net
Tue Oct 12 12:18:20 UTC 2021
On Mon, 11 Oct 2021 18:40:00 GMT, William Kemper <wkemper at openjdk.org> wrote:
> * Removed ShenandoahUseSimpleCardScanning and ShenandoahPromoteTenuredRegions command line options
> * Removed preprocessor directives FAST_REMEMBERED_SET_SCANNING and CROSSING_OFFSETS_NO_LONGER_NEEDED
Looks good to me, with one very minor nit (and really your choice).
src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 541:
> 539: ShenandoahCardCluster(RememberedSet *rs) {
> 540: _rs = rs;
> 541: // HEY! We don't really need object_starts entries for every card entry. We only need these for
Consider changing 'HEY!' to 'TODO' or something. IDEs tend to highlight the latter (mine does).
-------------
Marked as reviewed by rkennke (Lead).
PR: https://git.openjdk.java.net/shenandoah/pull/85
More information about the shenandoah-dev
mailing list