RFR: Reset coalesce and fill boundary during global collect
Kelvin Nilsen
kdnilsen at openjdk.java.net
Fri Oct 15 15:55:15 UTC 2021
On Thu, 14 Oct 2021 22:27:49 GMT, William Kemper <wkemper at openjdk.org> wrote:
> Normally, this happens during cset selection for the old generation. It also needs to happen for coalesce and fill at the end of global collections or objects may not be filled.
Marked as reviewed by kdnilsen (Committer).
Sorry to be so slow to see how this works. I see that the old-gen coalesce-and-fill effort instantiates a ShenandoahConcurrentCoalesceAndFillTask to perform coalesce-and-fill with preemption, and does not call into ShenandoahHeap::coalesce_and_fill_old_regions(), so I agree your change is ok.
It might be worthwhile to add a comment to ShenandoahHeap::coalesce_and_fill_old_regions() stating that this version of coalesce-and-fill is intended only for situations that do not need to respond to preemption requests by urgent young-gen collections.
-------------
PR: https://git.openjdk.java.net/shenandoah/pull/90
More information about the shenandoah-dev
mailing list