RFR: 8273597: Rectify Thread::is_ConcurrentGC_thread() [v2]
Stefan Karlsson
stefank at openjdk.java.net
Mon Sep 13 12:24:57 UTC 2021
On Mon, 13 Sep 2021 12:09:15 GMT, Per Liden <pliden at openjdk.org> wrote:
>> I wonder if adding a helper function would encourage people to think they're the same again.
>
> All three places doesn't quite have identical conditions today. We might want to clean this up, for example, I'd argue that at least one of the asserts could be removed. However, I'm not sure I want to do such a cleanup of a fairly unrelated thing as part of this PR.
I agree. I missed that one of the one of them is_at_safepoint and not is_gc_active.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5463
More information about the shenandoah-dev
mailing list