From wkemper at openjdk.java.net Tue Apr 5 23:36:31 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Tue, 5 Apr 2022 23:36:31 GMT Subject: RFR: Relax enforcement of evacuation budget Message-ID: Allow evacuation threads to allocate more memory than was anticipated when the collection set was chosen. Evacuation may use more memory because of increases in the size of TLABs. ------------- Commit messages: - Stop tracking young evac expanded - Relax enforcement of evacuation budget (reserve) Changes: https://git.openjdk.java.net/shenandoah/pull/129/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=129&range=00 Stats: 95 lines in 11 files changed: 2 ins; 81 del; 12 mod Patch: https://git.openjdk.java.net/shenandoah/pull/129.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/129/head:pull/129 PR: https://git.openjdk.java.net/shenandoah/pull/129 From kdnilsen at openjdk.java.net Wed Apr 6 18:18:18 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Wed, 6 Apr 2022 18:18:18 GMT Subject: RFR: Relax enforcement of evacuation budget In-Reply-To: References: Message-ID: <5DzjkGo4FTu-UczWktZaEGazLeF3hgFfjg6C6ovsBEs=.07a13450-15e1-47ff-8ec0-d9f018404cb2@github.com> On Tue, 5 Apr 2022 23:29:50 GMT, William Kemper wrote: > Allow evacuation threads to allocate more memory than was anticipated when the collection set was chosen. Evacuation may use more memory because of increases in the size of TLABs. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/129 From wkemper at openjdk.java.net Wed Apr 6 18:40:18 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Wed, 6 Apr 2022 18:40:18 GMT Subject: Integrated: Relax enforcement of evacuation budget In-Reply-To: References: Message-ID: <5fMoDtseckwiBo3ih97w7QMRzFyio4z21eBDDDljF38=.e79d78ae-8429-4a51-a435-d1b1e6b556a3@github.com> On Tue, 5 Apr 2022 23:29:50 GMT, William Kemper wrote: > Allow evacuation threads to allocate more memory than was anticipated when the collection set was chosen. Evacuation may use more memory because of increases in the size of TLABs. This pull request has now been integrated. Changeset: 54f1e496 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/54f1e49604b2c4e91b4f484de24cefed4409ecf2 Stats: 95 lines in 11 files changed: 2 ins; 81 del; 12 mod Relax enforcement of evacuation budget Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/129 From andrew at openjdk.java.net Fri Apr 8 16:56:25 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Fri, 8 Apr 2022 16:56:25 GMT Subject: git: openjdk/shenandoah-jdk8u: master: 8282458: Update .jcheck/conf file for sh-jdk8u move to git Message-ID: <79e5557d-e026-46df-bb86-782a2852ca66@openjdk.org> Changeset: 7e41f275 Author: Andrew John Hughes Date: 2022-02-15 18:20:57 +0000 URL: https://git.openjdk.java.net/shenandoah-jdk8u/commit/7e41f275945442f3daab33ea920c0000b4fa9cc1 8282458: Update .jcheck/conf file for sh-jdk8u move to git + .jcheck/conf From dholmes at openjdk.java.net Mon Apr 11 10:40:36 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Mon, 11 Apr 2022 10:40:36 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v24] In-Reply-To: References:

Message-ID: <-3pH-9NVTEgTBaWbZ05s8pSHxZZIwMFUlgxPpqvke8s=.2a1299f4-6bc4-46b1-8cea-181fb17e6f6a@github.com> On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. >> >> [1] - https://openjdk.java.net/jeps/424 > > Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: > > Fix TestLinkToNativeRBP VM changes look good. Thanks, David src/hotspot/share/prims/scopedMemoryAccess.cpp line 141: > 139: > 140: /* > 141: * This function performs a thread-local handshake against all threads running at the time Nit: thread-local?? ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Mon Apr 11 12:07:34 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Mon, 11 Apr 2022 12:07:34 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v24] In-Reply-To: <-3pH-9NVTEgTBaWbZ05s8pSHxZZIwMFUlgxPpqvke8s=.2a1299f4-6bc4-46b1-8cea-181fb17e6f6a@github.com> References:

<-3pH-9NVTEgTBaWbZ05s8pSHxZZIwMFUlgxPpqvke8s=.2a1299f4-6bc4-46b1-8cea-181fb17e6f6a@github.com> Message-ID: On Mon, 11 Apr 2022 10:33:54 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix TestLinkToNativeRBP > > src/hotspot/share/prims/scopedMemoryAccess.cpp line 141: > >> 139: >> 140: /* >> 141: * This function performs a thread-local handshake against all threads running at the time > > Nit: thread-local?? I was assuming the term "thread-local handshake" was a thing in the VM, as per: https://openjdk.java.net/jeps/312 ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Mon Apr 11 17:29:56 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Mon, 11 Apr 2022 17:29:56 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v25] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Fix UnrolledAccess benchmark ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/d84de510..c9afcd17 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=24 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=23-24 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Mon Apr 11 18:36:48 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Mon, 11 Apr 2022 18:36:48 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v26] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Use a less expensive array element alignment check The bit to byte conversion shows up in hot paths ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/c9afcd17..a68195ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=25 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=24-25 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From wkemper at openjdk.java.net Mon Apr 11 21:20:49 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Mon, 11 Apr 2022 21:20:49 GMT Subject: RFR: Cool down regulator after request to start GC is accepted Message-ID: Have the regulator wait for the gc state to change after the control thread accepts the request to start a cycle. ------------- Commit messages: - Locker safepoint check needs to match lock - Cool down regulator after gc request is accepted Changes: https://git.openjdk.java.net/shenandoah/pull/130/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=130&range=00 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/shenandoah/pull/130.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/130/head:pull/130 PR: https://git.openjdk.java.net/shenandoah/pull/130 From kdnilsen at openjdk.java.net Mon Apr 11 22:50:23 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Mon, 11 Apr 2022 22:50:23 GMT Subject: RFR: Cool down regulator after request to start GC is accepted In-Reply-To: References: Message-ID: <4kH5izBGkKizNZEUkC0Q3ozsRAnRdYMtwa07SBzhTaU=.178a5e22-4c7a-4daf-a224-3a21b137ec04@github.com> On Mon, 11 Apr 2022 21:14:40 GMT, William Kemper wrote: > Have the regulator wait for the gc state to change after the control thread accepts the request to start a cycle. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/130 From dholmes at openjdk.java.net Mon Apr 11 22:51:08 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Mon, 11 Apr 2022 22:51:08 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v24] In-Reply-To: References:

<-3pH-9NVTEgTBaWbZ05s8pSHxZZIwMFUlgxPpqvke8s=.2a1299f4-6bc4-46b1-8cea-181fb17e6f6a@github.com> Message-ID: On Mon, 11 Apr 2022 12:04:41 GMT, Maurizio Cimadamore wrote: >> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141: >> >>> 139: >>> 140: /* >>> 141: * This function performs a thread-local handshake against all threads running at the time >> >> Nit: thread-local?? > > I was assuming the term "thread-local handshake" was a thing in the VM, as per: > https://openjdk.java.net/jeps/312 Ha! Mea culpa. I've been too buried in the other kind of thread-local lately. I completely forgot we actually described handshakes that way. :) ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Tue Apr 12 10:24:47 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 12 Apr 2022 10:24:47 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v27] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Add @ForceInline annotation on session accessor Beef up UnrolledAccess benchmark ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/a68195ae..66cebe77 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=26 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=25-26 Stats: 32 lines in 2 files changed: 32 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From wkemper at openjdk.java.net Tue Apr 12 16:29:16 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Tue, 12 Apr 2022 16:29:16 GMT Subject: Integrated: Cool down regulator after request to start GC is accepted In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 21:14:40 GMT, William Kemper wrote: > Have the regulator wait for the gc state to change after the control thread accepts the request to start a cycle. This pull request has now been integrated. Changeset: 278ecdc5 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/278ecdc56accfe26cf7fdab59d11a8e4926092a9 Stats: 9 lines in 2 files changed: 8 ins; 0 del; 1 mod Cool down regulator after request to start GC is accepted Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/130 From alanb at openjdk.java.net Wed Apr 13 16:16:23 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Wed, 13 Apr 2022 16:16:23 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v27] In-Reply-To: References:

Message-ID: On Tue, 12 Apr 2022 10:24:47 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. >> >> [1] - https://openjdk.java.net/jeps/424 > > Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: > > Add @ForceInline annotation on session accessor > Beef up UnrolledAccess benchmark src/java.base/share/classes/java/nio/channels/FileChannel.java line 1052: > 1050: public MemorySegment map(MapMode mode, long offset, long size, > 1051: MemorySession session) > 1052: throws IOException, UnsupportedOperationException Just a minor here is that UOE is a runtime exception so probably shouldn't be in the throws. ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From wkemper at openjdk.java.net Wed Apr 13 17:39:08 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Wed, 13 Apr 2022 17:39:08 GMT Subject: RFR: Improved timing reports Message-ID: This is a bundle of a few minor changes to the cycle and global timing reports: * Render coalescing phase closer to where it happens in the cycle * Include timing for remembered set swap and satb management during init mark pause * Emit a cycle report for old generation's bootstrap cycle * Track old GC cycles completed and interrupted for global report ------------- Commit messages: - Keep track of completed and interrupted old GC counts - Emit separate report for old GC's bootstrap cycle - Add phase timing for rset swap and satb transfer - Report coalescing phase in timing report closer to the order in which it happens Changes: https://git.openjdk.java.net/shenandoah/pull/131/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=131&range=00 Stats: 89 lines in 6 files changed: 58 ins; 27 del; 4 mod Patch: https://git.openjdk.java.net/shenandoah/pull/131.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/131/head:pull/131 PR: https://git.openjdk.java.net/shenandoah/pull/131 From kdnilsen at openjdk.java.net Wed Apr 13 20:39:48 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Wed, 13 Apr 2022 20:39:48 GMT Subject: RFR: Improved timing reports In-Reply-To: References: Message-ID: On Wed, 13 Apr 2022 17:33:28 GMT, William Kemper wrote: > This is a bundle of a few minor changes to the cycle and global timing reports: > * Render coalescing phase closer to where it happens in the cycle > * Include timing for remembered set swap and satb management during init mark pause > * Emit a cycle report for old generation's bootstrap cycle > * Track old GC cycles completed and interrupted for global report Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/131 From mcimadamore at openjdk.java.net Wed Apr 13 21:30:17 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 13 Apr 2022 21:30:17 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v27] In-Reply-To: References:

Message-ID: On Wed, 13 Apr 2022 16:12:31 GMT, Alan Bateman wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: >> >> Add @ForceInline annotation on session accessor >> Beef up UnrolledAccess benchmark > > src/java.base/share/classes/java/nio/channels/FileChannel.java line 1052: > >> 1050: public MemorySegment map(MapMode mode, long offset, long size, >> 1051: MemorySession session) >> 1052: throws IOException, UnsupportedOperationException > > Just a minor here is that UOE is a runtime exception so probably shouldn't be in the throws. whoops - good catch - will fix! ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Wed Apr 13 21:35:07 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 13 Apr 2022 21:35:07 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v28] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Drop `UnsupportedOperationException` from throws clause in FileChannel/FileChannelImpl ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/66cebe77..3a87df5e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=27 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=26-27 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Wed Apr 13 21:36:58 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 13 Apr 2022 21:36:58 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v29] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Remove whitespaces ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/3a87df5e..8637379e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=28 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=27-28 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Thu Apr 14 12:01:30 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 14 Apr 2022 12:01:30 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v30] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with four additional commits since the last revision: - Add ValueLayout changes - Tweak support for array element var handle - Add @see - Initial push ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/8637379e..2e3d57a8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=29 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=28-29 Stats: 129 lines in 4 files changed: 97 ins; 25 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From wkemper at openjdk.java.net Thu Apr 14 21:21:25 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Thu, 14 Apr 2022 21:21:25 GMT Subject: Integrated: Improved timing reports In-Reply-To: References: Message-ID: <3QlG8N_2tPXe_MW9h5gYmmGH8F3PXh41dMHbKTs0aXA=.db1dd430-56a6-4ad7-a92f-2424118986ea@github.com> On Wed, 13 Apr 2022 17:33:28 GMT, William Kemper wrote: > This is a bundle of a few minor changes to the cycle and global timing reports: > * Render coalescing phase closer to where it happens in the cycle > * Include timing for remembered set swap and satb management during init mark pause > * Emit a cycle report for old generation's bootstrap cycle > * Track old GC cycles completed and interrupted for global report This pull request has now been integrated. Changeset: ca2cf6b8 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/ca2cf6b871cc3ed250ad75c72a8a8330efd28f05 Stats: 89 lines in 6 files changed: 58 ins; 27 del; 4 mod Improved timing reports Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/131 From ihse at openjdk.java.net Fri Apr 15 07:47:15 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 15 Apr 2022 07:47:15 GMT Subject: RFR: 8284903: Fix typos in hotspot Message-ID: I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... ------------- Commit messages: - Pass #2 - Pass #1 in shared code - Pass #1 in platform-specific code Changes: https://git.openjdk.java.net/jdk/pull/8260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8260&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284903 Stats: 910 lines in 446 files changed: 0 ins; 0 del; 910 mod Patch: https://git.openjdk.java.net/jdk/pull/8260.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8260/head:pull/8260 PR: https://git.openjdk.java.net/jdk/pull/8260 From wkemper at openjdk.java.net Fri Apr 15 15:55:41 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 15 Apr 2022 15:55:41 GMT Subject: RFR: Include mark worker performance in report for concurrent mark phase Message-ID: This will allow us to detect an uneven distribution of work among the mark threads. ------------- Commit messages: - Include mark worker performance in report for concurrent mark phase Changes: https://git.openjdk.java.net/shenandoah/pull/132/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=132&range=00 Stats: 4 lines in 3 files changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/shenandoah/pull/132.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/132/head:pull/132 PR: https://git.openjdk.java.net/shenandoah/pull/132 From kdnilsen at openjdk.java.net Fri Apr 15 17:39:15 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Fri, 15 Apr 2022 17:39:15 GMT Subject: RFR: Include mark worker performance in report for concurrent mark phase In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 15:48:39 GMT, William Kemper wrote: > This will allow us to detect an uneven distribution of work among the mark threads. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/132 From cjplummer at openjdk.java.net Fri Apr 15 19:30:34 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Fri, 15 Apr 2022 19:30:34 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... I tried to cover all serviceability files, but didn't want to pick and choose individual files within any given directory, so I reviewed all files in any directory that contained a serviceability related file. So the following were covered by my review: src/os src/os_cpu src/share/prims src/share/services src/hotspot/share/prims/jvmtiThreadState.hpp line 136: > 134: ~JvmtiThreadState(); > 135: > 136: // is event_type enabled and usable for this thread in any environments? Should it be "environment"? src/hotspot/share/services/memTracker.hpp line 128: > 126: > 127: // Record arena size change. Arena size is the size of all arena > 128: // chunks that backing up the arena. This doesn't read correctly (not due to your change). Perhaps "that back up" or "that are backing up" is what was intended. ------------- Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From wkemper at openjdk.java.net Fri Apr 15 23:25:20 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 15 Apr 2022 23:25:20 GMT Subject: Integrated: Include mark worker performance in report for concurrent mark phase In-Reply-To: References: Message-ID: <8s-ch0AEaJJlkPB-Hyqj_gWHVWxiC7F-R52bkFaeWKg=.ad317dcb-25b8-4f4b-b977-830d2cf79dad@github.com> On Fri, 15 Apr 2022 15:48:39 GMT, William Kemper wrote: > This will allow us to detect an uneven distribution of work among the mark threads. This pull request has now been integrated. Changeset: 199e8080 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/199e8080174a529dc8153f1196b767baa199d501 Stats: 4 lines in 3 files changed: 3 ins; 0 del; 1 mod Include mark worker performance in report for concurrent mark phase Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/132 From coleenp at openjdk.java.net Mon Apr 18 18:00:40 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 18 Apr 2022 18:00:40 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... I checked all directories except gc, jfr, metaspace, opto and jvmti. It's surprising that there aren't more typos. The changes to each file are tiny (one word to three words). ------------- Marked as reviewed by coleenp (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From kvn at openjdk.java.net Mon Apr 18 18:40:40 2022 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Mon, 18 Apr 2022 18:40:40 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: <0CKX2hdjVTCzFrtYznCHOfTWFFkRvKBfQilIOETpBK4=.b72aaefe-d6c6-4a2e-ba29-cc6198576d91@github.com> On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Nice work! I reviewed compiler related code: `cpu`, `os`, `os_cpu`, `share/adlc`, `share/c1`, `share/ci`, `share/code`, `share/compiler`, `share/jvmci`, `share/opto`. ------------- Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From dholmes at openjdk.java.net Tue Apr 19 00:26:42 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Tue, 19 Apr 2022 00:26:42 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Hi Magnus, Generally looks good. Thanks for doing this extremely tedious cleanup. A few comments/suggestions/corrections below. And of course copyright dates need updating for Oracle copyrights. Thanks, David src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp line 125: > 123: bool LIRGenerator::can_store_as_constant(Value v, BasicType type) const { > 124: if (type == T_SHORT || type == T_CHAR) { > 125: // there is no immediate move of word values in assembler_i486.?pp Dead comment as there is no such file any more. src/hotspot/cpu/x86/macroAssembler_x86.hpp line 865: > 863: > 864: // 32bit can do a case table jump in one instruction but we no longer allow the base > 865: // to be installed in the Address class. This jump will transfers to the address transfer not transfers src/hotspot/share/c1/c1_Runtime1.cpp line 552: > 550: Exceptions::debug_check_abort(exception); > 551: > 552: // Check the stack guard pages and re-enable them if necessary and there is Curious how inconsistent hyphenation rules are in English :) I would use reenable in the same way we use mismatch. src/hotspot/share/code/nmethod.cpp line 2906: > 2904: > 2905: // Compressed undisassembled disassembly format. > 2906: // The following statuses are defined/supported: status is the more usual self-plural - or use "status values" src/hotspot/share/runtime/os.cpp line 644: > 642: DEBUG_ONLY(check_crash_protection()); > 643: > 644: // On malloc(0), implementers of malloc(3) have the choice to return either I suggest "implementations of malloc..." src/hotspot/share/runtime/task.hpp line 72: > 70: void enroll(); > 71: > 72: // Make the task deactivate Should be "inactive" src/hotspot/share/services/threadIdTable.cpp line 94: > 92: if (!_is_initialized) { > 93: { > 94: // There is no obvious benefits in allowing the thread table s/benefits/benefit/ src/hotspot/share/services/threadIdTable.cpp line 95: > 93: { > 94: // There is no obvious benefits in allowing the thread table > 95: // to be concurrently populated during the initialization. delete "the" ------------- Changes requested by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From dnsimon at openjdk.java.net Tue Apr 19 08:52:28 2022 From: dnsimon at openjdk.java.net (Doug Simon) Date: Tue, 19 Apr 2022 08:52:28 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Are there plans to add `codespell` to the make system to somehow catch/prevent spelling regressions in future? I understand this may not be feasible. ------------- PR: https://git.openjdk.java.net/jdk/pull/8260 From duke at openjdk.java.net Tue Apr 19 09:01:25 2022 From: duke at openjdk.java.net (XenoAmess) Date: Tue, 19 Apr 2022 09:01:25 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References:

Message-ID: On Tue, 19 Apr 2022 08:49:28 GMT, Doug Simon wrote: > Are there plans to add `codespell` to the make system to somehow catch/prevent spelling regressions in future? I understand this may not be feasible. IMO all spell checking mechanisms suffers from false positive and need human manual job to filter them... So maybe we can only arrange a scan per year or per months... ------------- PR: https://git.openjdk.java.net/jdk/pull/8260 From ihse at openjdk.java.net Tue Apr 19 14:04:25 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 19 Apr 2022 14:04:25 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Thank you for all your input! I will update the PR according to all suggestions. But let me answer a few more general comments first. The spelling corrections in this PR was generated by codespell. I manually removed all false positives (that was the most tedious part of this fix). Codespell works by checking a list of commonly misspelled words, not by verifying that all words are present in a list of accepted spellings. The latter approach might work for normal prose, but is utterly worthless for source code. In practice, codespell does automatically what several users have been doing manually lately -- discover a common misspelling, searching the code base for more instances of that misspelling. So, there are certainly lots of typos left. But this should reasonably cut down on the number of PRs of the type "Fix typos for supercalifragilisticexpialidocious" that updates a lot of files for just a single misspelled word. For some cases where I were not sure (like mismatch or re-enable), I googled, read spelling recommendations and/or checked how common alternative spellings where. When the ratio exceeded 10:1 or so, I deemed one alternative as "correct"; in less common cases I let the original authors choice of spelling remain. I have not read the complete sentences, just verified that the actual word fixes seemed to make sense. Hence the odd results in some places. Ideally, I would like to find some way of keeping the code "codespell clean" using tooling. Due to the amount of false positives, this is not a trivial task. I don't think we'll ever be able to have it as part of jcheck, but we might have a script that someone runs once per release or so. I'm not yet sure how to achieve this, but my two main ideas is to either just run codespell on added or modified code (think "+" lines in git diff), or to have a list of acknowledged false positives that should be skipped. Before I can even start on this, the huge number of *true* positives needs to be addressed, though! Hotspot is by no means worst, it's just a huge chunk of code which I addressed all at once. ------------- PR: https://git.openjdk.java.net/jdk/pull/8260 From lucy at openjdk.java.net Tue Apr 19 17:32:25 2022 From: lucy at openjdk.java.net (Lutz Schmidt) Date: Tue, 19 Apr 2022 17:32:25 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... This is a partial approval for - cpu/ppc - cpu/s390 - os/aix - os_cpu/aix_ppc - os_cpu/linux_ppc - os_cpu/linux_s390 Thank you for completing this tedious job! ------------- Marked as reviewed by lucy (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From stefank at openjdk.java.net Tue Apr 19 18:06:25 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 19 Apr 2022 18:06:25 GMT Subject: RFR: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Reviewed: - gc/ - oops/ - utilities/ ------------- Marked as reviewed by stefank (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8260 From ihse at openjdk.java.net Tue Apr 19 19:08:26 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 19 Apr 2022 19:08:26 GMT Subject: RFR: 8284903: Fix typos in hotspot [v2] In-Reply-To: References: Message-ID: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Fix some places according to code reviews ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8260/files - new: https://git.openjdk.java.net/jdk/pull/8260/files/449d8a23..28bb365f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8260&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8260&range=00-01 Stats: 9 lines in 8 files changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/8260.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8260/head:pull/8260 PR: https://git.openjdk.java.net/jdk/pull/8260 From ihse at openjdk.java.net Tue Apr 19 19:13:03 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 19 Apr 2022 19:13:03 GMT Subject: RFR: 8284903: Fix typos in hotspot [v3] In-Reply-To: References: Message-ID: <3Is0RhXgzstSAZW41f6AGki3RZtWmBm8x4yuRZSz4OE=.da5d7f88-92e4-4a3f-9e5c-407d768d3618@github.com> > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Update copyright headers ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8260/files - new: https://git.openjdk.java.net/jdk/pull/8260/files/28bb365f..4fc36d6b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8260&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8260&range=01-02 Stats: 287 lines in 287 files changed: 0 ins; 0 del; 287 mod Patch: https://git.openjdk.java.net/jdk/pull/8260.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8260/head:pull/8260 PR: https://git.openjdk.java.net/jdk/pull/8260 From ihse at openjdk.java.net Tue Apr 19 19:14:02 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 19 Apr 2022 19:14:02 GMT Subject: Integrated: 8284903: Fix typos in hotspot In-Reply-To: References: Message-ID: On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... This pull request has now been integrated. Changeset: 4594696f Author: Magnus Ihse Bursie URL: https://git.openjdk.java.net/jdk/commit/4594696f5462995ec58ca1d2c1bde7cc857c5caf Stats: 1197 lines in 446 files changed: 0 ins; 1 del; 1196 mod 8284903: Fix typos in hotspot Reviewed-by: cjplummer, coleenp, kvn, lucy, stefank ------------- PR: https://git.openjdk.java.net/jdk/pull/8260 From wkemper at openjdk.java.net Tue Apr 19 23:52:25 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Tue, 19 Apr 2022 23:52:25 GMT Subject: RFR: Fix concurrent mark worker timings Message-ID: When we added working timings for concurrent mark, they only reported the timing of the last iteration of the top level mark loop (which iteratively flushes SATB buffers on thread local handshakes). This changes adds an option to accumulate the workers' timing values. ------------- Commit messages: - Fix concurrent mark worker timings Changes: https://git.openjdk.java.net/shenandoah/pull/133/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=133&range=00 Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/shenandoah/pull/133.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/133/head:pull/133 PR: https://git.openjdk.java.net/shenandoah/pull/133 From kdnilsen at openjdk.java.net Wed Apr 20 03:33:08 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Wed, 20 Apr 2022 03:33:08 GMT Subject: RFR: Fix concurrent mark worker timings In-Reply-To: References: Message-ID: On Tue, 19 Apr 2022 23:45:45 GMT, William Kemper wrote: > When we added working timings for concurrent mark, they only reported the timing of the last iteration of the top level mark loop (which iteratively flushes SATB buffers on thread local handshakes). This changes adds an option to accumulate the workers' timing values. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/133 From dholmes at openjdk.java.net Wed Apr 20 06:23:27 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Wed, 20 Apr 2022 06:23:27 GMT Subject: RFR: 8284903: Fix typos in hotspot [v2] In-Reply-To: References:

Message-ID: On Tue, 19 Apr 2022 19:08:26 GMT, Magnus Ihse Bursie wrote: >> I ran `codespell` on hotspot, and accepted those changes where it indeed discovered real typos. >> >> You'd be surprised over the many implementions of instrinsics and other intructions accross all archtectures I've encounted, so for the preceding reason it's neccesery to sucessfully seach for exisiting typos... > > Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: > > Fix some places according to code reviews src/hotspot/share/runtime/task.hpp line 72: > 70: void enroll(); > 71: > 72: // Make the task inactivate That should have been "inactive". ------------- PR: https://git.openjdk.java.net/jdk/pull/8260 From wkemper at openjdk.java.net Wed Apr 20 15:57:08 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Wed, 20 Apr 2022 15:57:08 GMT Subject: Integrated: Fix concurrent mark worker timings In-Reply-To: References: Message-ID: On Tue, 19 Apr 2022 23:45:45 GMT, William Kemper wrote: > When we added working timings for concurrent mark, they only reported the timing of the last iteration of the top level mark loop (which iteratively flushes SATB buffers on thread local handshakes). This changes adds an option to accumulate the workers' timing values. This pull request has now been integrated. Changeset: b759dab2 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/b759dab2c7d1f89cbb4e23ae331f828173acdf18 Stats: 6 lines in 3 files changed: 1 ins; 0 del; 5 mod Fix concurrent mark worker timings Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/133 From wkemper at openjdk.java.net Wed Apr 20 16:18:42 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Wed, 20 Apr 2022 16:18:42 GMT Subject: RFR: Use state from collection set to know if mixed collection is in progress Message-ID: <_anEoJ0_RNCBPmwOySM-pSrKxrvqznfsG47bphhAM-g=.65cff631-07f3-4da7-8472-6478924951fc@github.com> The state that indicated when a mixed collection was in progress was represented in two places: a property of the collection set and a member variable on the heap set after the collection set was chosen. In some cases, a degenerated cycle could cause the heap's member variable to become stale (indicating a mixed evac was in progress when it was not). In this case, update references could fail to update references in old regions with an incomplete mark bitmap. With this change, update references uses the property of the collection set to know if a mixed evacuation is in progress. ------------- Commit messages: - Use state from collection set to know if mixed collection is in progress Changes: https://git.openjdk.java.net/shenandoah/pull/134/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=134&range=00 Stats: 42 lines in 11 files changed: 0 ins; 23 del; 19 mod Patch: https://git.openjdk.java.net/shenandoah/pull/134.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/134/head:pull/134 PR: https://git.openjdk.java.net/shenandoah/pull/134 From kdnilsen at openjdk.java.net Wed Apr 20 18:07:11 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Wed, 20 Apr 2022 18:07:11 GMT Subject: RFR: Use state from collection set to know if mixed collection is in progress In-Reply-To: <_anEoJ0_RNCBPmwOySM-pSrKxrvqznfsG47bphhAM-g=.65cff631-07f3-4da7-8472-6478924951fc@github.com> References: <_anEoJ0_RNCBPmwOySM-pSrKxrvqznfsG47bphhAM-g=.65cff631-07f3-4da7-8472-6478924951fc@github.com> Message-ID: On Wed, 20 Apr 2022 16:10:49 GMT, William Kemper wrote: > The state that indicated when a mixed collection was in progress was represented in two places: a property of the collection set and a member variable on the heap set after the collection set was chosen. In some cases, a degenerated cycle could cause the heap's member variable to become stale (indicating a mixed evac was in progress when it was not). In this case, update references could fail to update references in old regions with an incomplete mark bitmap. With this change, update references uses the property of the collection set to know if a mixed evacuation is in progress. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/134 From wkemper at openjdk.java.net Wed Apr 20 18:18:21 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Wed, 20 Apr 2022 18:18:21 GMT Subject: Integrated: Use state from collection set to know if mixed collection is in progress In-Reply-To: <_anEoJ0_RNCBPmwOySM-pSrKxrvqznfsG47bphhAM-g=.65cff631-07f3-4da7-8472-6478924951fc@github.com> References: <_anEoJ0_RNCBPmwOySM-pSrKxrvqznfsG47bphhAM-g=.65cff631-07f3-4da7-8472-6478924951fc@github.com> Message-ID: On Wed, 20 Apr 2022 16:10:49 GMT, William Kemper wrote: > The state that indicated when a mixed collection was in progress was represented in two places: a property of the collection set and a member variable on the heap set after the collection set was chosen. In some cases, a degenerated cycle could cause the heap's member variable to become stale (indicating a mixed evac was in progress when it was not). In this case, update references could fail to update references in old regions with an incomplete mark bitmap. With this change, update references uses the property of the collection set to know if a mixed evacuation is in progress. This pull request has now been integrated. Changeset: 5ec87a5d Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/5ec87a5da0a95135039ab2ec13659ffee3e8e551 Stats: 42 lines in 11 files changed: 0 ins; 23 del; 19 mod Use state from collection set to know if mixed collection is in progress Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/134 From kdnilsen at openjdk.java.net Fri Apr 22 15:47:29 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Fri, 22 Apr 2022 15:47:29 GMT Subject: RFR: Only clear requested gc cause when it is handled In-Reply-To: <_C_R7pjiho9tZxXWR_0zWizr3DCXfQNzbGKCeT95Wk8=.54cf016c-b3b3-4939-a8f7-a505809c8461@github.com> References: <_C_R7pjiho9tZxXWR_0zWizr3DCXfQNzbGKCeT95Wk8=.54cf016c-b3b3-4939-a8f7-a505809c8461@github.com> Message-ID: On Fri, 22 Apr 2022 15:38:52 GMT, William Kemper wrote: > Do not unconditionally clear `_requested_gc_cause` on every idle iteration of the control loop as this may erroneously over-write a request to perform a GC cycle. With this change, `_requested_gc_cause` is only cleared when a gc request is handled. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/135 From wkemper at openjdk.java.net Fri Apr 22 15:47:29 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 22 Apr 2022 15:47:29 GMT Subject: RFR: Only clear requested gc cause when it is handled Message-ID: <_C_R7pjiho9tZxXWR_0zWizr3DCXfQNzbGKCeT95Wk8=.54cf016c-b3b3-4939-a8f7-a505809c8461@github.com> Do not unconditionally clear `_requested_gc_cause` on every idle iteration of the control loop as this may erroneously over-write a request to perform a GC cycle. With this change, `_requested_gc_cause` is only cleared when a gc request is handled. ------------- Commit messages: - Only clear requested gc cause when it is handled Changes: https://git.openjdk.java.net/shenandoah/pull/135/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=135&range=00 Stats: 32 lines in 3 files changed: 25 ins; 6 del; 1 mod Patch: https://git.openjdk.java.net/shenandoah/pull/135.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/135/head:pull/135 PR: https://git.openjdk.java.net/shenandoah/pull/135 From wkemper at openjdk.java.net Fri Apr 22 17:11:14 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 22 Apr 2022 17:11:14 GMT Subject: Integrated: Only clear requested gc cause when it is handled In-Reply-To: <_C_R7pjiho9tZxXWR_0zWizr3DCXfQNzbGKCeT95Wk8=.54cf016c-b3b3-4939-a8f7-a505809c8461@github.com> References: <_C_R7pjiho9tZxXWR_0zWizr3DCXfQNzbGKCeT95Wk8=.54cf016c-b3b3-4939-a8f7-a505809c8461@github.com> Message-ID: On Fri, 22 Apr 2022 15:38:52 GMT, William Kemper wrote: > Do not unconditionally clear `_requested_gc_cause` on every idle iteration of the control loop as this may erroneously over-write a request to perform a GC cycle. With this change, `_requested_gc_cause` is only cleared when a gc request is handled. This pull request has now been integrated. Changeset: bdd7667a Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/bdd7667ad0dcfd46871edcfbe67aade6b27d1455 Stats: 32 lines in 3 files changed: 25 ins; 6 del; 1 mod Only clear requested gc cause when it is handled Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/135 From mcimadamore at openjdk.java.net Wed Apr 27 10:25:34 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 27 Apr 2022 10:25:34 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v31] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 50 commits: - Merge branch 'master' into foreign-preview - Add ValueLayout changes - Tweak support for array element var handle - Add @see - Initial push - Remove whitespaces - Drop `UnsupportedOperationException` from throws clause in FileChannel/FileChannelImpl - Add @ForceInline annotation on session accessor Beef up UnrolledAccess benchmark - Use a less expensive array element alignment check The bit to byte conversion shows up in hot paths - Fix UnrolledAccess benchmark - ... and 40 more: https://git.openjdk.java.net/jdk/compare/72f82dd7...746de5ce ------------- Changes: https://git.openjdk.java.net/jdk/pull/7888/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=30 Stats: 65314 lines in 367 files changed: 43344 ins; 19432 del; 2538 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Wed Apr 27 11:49:42 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 27 Apr 2022 11:49:42 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v32] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Address CSR comments ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/746de5ce..6990183f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=31 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=30-31 Stats: 114 lines in 9 files changed: 36 ins; 0 del; 78 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Wed Apr 27 12:00:29 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 27 Apr 2022 12:00:29 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v33] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Simplify libraryLookup impl ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/6990183f..5866bbb5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=32 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=31-32 Stats: 21 lines in 1 file changed: 6 ins; 11 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From kdnilsen at openjdk.java.net Thu Apr 28 16:28:02 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Thu, 28 Apr 2022 16:28:02 GMT Subject: RFR: Balance without cancel Message-ID: <_l1IqN_QrbTy3hsL54uJQe4swcli1hnNlh0pL9HI5Uw=.467c66b0-4b21-4fcf-80de-71b11b1beb73@github.com> This commit does load balancing on remembered set scanning that happens during concurrent marking and during concurrent updating of references. Experiments show that the concurrency of remembered set marking is now much closer to the number of concurrent GC threads (generally within 5%) whereas before this commit, the level of concurrency was often less than 1/4 of the number of concurrent GC threads. An additional fix integrated in this commit is to not scan the entirety of humongous object arrays. We only scan the portions of these arrays that overlay with dirty cards in the remembered set. ------------- Commit messages: - Fix whitespace errors - Merge remote-tracking branch 'GitFarmBranch/balance-without-cancel' into balance-without-cancel - Remove instrumentation - Fix up miscalculations for memory loaned from old-gen - Fix assertion error - Only clear requested gc cause when it is handled - Use state from collection set to know if mixed collection is in progress - Fix concurrent mark worker timings - Include mark worker performance in report for concurrent mark phase - Improved timing reports - ... and 27 more: https://git.openjdk.java.net/shenandoah/compare/bdd7667a...98be07c7 Changes: https://git.openjdk.java.net/shenandoah/pull/136/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=136&range=00 Stats: 1487 lines in 23 files changed: 984 ins; 286 del; 217 mod Patch: https://git.openjdk.java.net/shenandoah/pull/136.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/136/head:pull/136 PR: https://git.openjdk.java.net/shenandoah/pull/136 From mcimadamore at openjdk.java.net Thu Apr 28 18:10:57 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 28 Apr 2022 18:10:57 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Downcall and upcall tests use wrong layout which is missing some trailing padding ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/5866bbb5..945317ec Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=33 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=32-33 Stats: 9 lines in 2 files changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From wkemper at openjdk.java.net Thu Apr 28 21:00:40 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Thu, 28 Apr 2022 21:00:40 GMT Subject: RFR: Allow regulator to schedule global cycles for the purpose of class unloading Message-ID: Generational mode only supports class unloading during _global_ cycles. Global cycles can only be triggered in generational mode by an explicit `System.gc` call. With this change, the regulator is able to trigger periodic global cycles based on the value of `ShenandoahUnloadClassesFrequency`. This is currently disabled by default for the generational mode because we've not found a workload that shows a clear benefit, however, we expect it will be needed for longer running workloads and we want the ability to turn this on when necessary. ------------- Commit messages: - Disable periodic concurrent class unloading cycles for generation mode - Dial back class unloading frequency to every 50 cycles - Bypass heuristic when we need to unload classes - Allow regulator to schedule periodic global collects Changes: https://git.openjdk.java.net/shenandoah/pull/138/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=138&range=00 Stats: 21 lines in 3 files changed: 15 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/shenandoah/pull/138.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/138/head:pull/138 PR: https://git.openjdk.java.net/shenandoah/pull/138 From wkemper at openjdk.java.net Thu Apr 28 21:25:32 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Thu, 28 Apr 2022 21:25:32 GMT Subject: RFR: Balance without cancel In-Reply-To: <_l1IqN_QrbTy3hsL54uJQe4swcli1hnNlh0pL9HI5Uw=.467c66b0-4b21-4fcf-80de-71b11b1beb73@github.com> References: <_l1IqN_QrbTy3hsL54uJQe4swcli1hnNlh0pL9HI5Uw=.467c66b0-4b21-4fcf-80de-71b11b1beb73@github.com> Message-ID: On Thu, 28 Apr 2022 04:12:58 GMT, Kelvin Nilsen wrote: > This commit does load balancing on remembered set scanning that happens during concurrent marking and during concurrent updating of references. Experiments show that the concurrency of remembered set marking is now much closer to the number of concurrent GC threads (generally within 5%) whereas before this commit, the level of concurrency was often less than 1/4 of the number of concurrent GC threads. > > An additional fix integrated in this commit is to not scan the entirety of humongous object arrays. We only scan the portions of these arrays that overlay with dirty cards in the remembered set. Can we break out the changes to the remembered set scan, the refactoring of collection set selection and the scanning of humongous objects into separate, testable changes? I have some concerns about the performance of this change. ------------- PR: https://git.openjdk.java.net/shenandoah/pull/136 From wkemper at openjdk.java.net Thu Apr 28 21:45:53 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Thu, 28 Apr 2022 21:45:53 GMT Subject: RFR: Include mixed and abbreviated cycle counts in summary report Message-ID: Include mixed and abbreviated cycle counts in summary report ------------- Commit messages: - Fix whitespace - Include mixed and abbreviated cycle counts in summary report Changes: https://git.openjdk.java.net/shenandoah/pull/137/files Webrev: https://webrevs.openjdk.java.net/?repo=shenandoah&pr=137&range=00 Stats: 28 lines in 3 files changed: 26 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/shenandoah/pull/137.diff Fetch: git fetch https://git.openjdk.java.net/shenandoah pull/137/head:pull/137 PR: https://git.openjdk.java.net/shenandoah/pull/137 From gli at openjdk.java.net Fri Apr 29 00:46:18 2022 From: gli at openjdk.java.net (Guoxiong Li) Date: Fri, 29 Apr 2022 00:46:18 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34] In-Reply-To: References:

Message-ID: On Thu, 28 Apr 2022 18:10:57 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. >> >> [1] - https://openjdk.java.net/jeps/424 > > Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: > > Downcall and upcall tests use wrong layout which is missing some trailing padding Remind: please use the command `/jep JEP-424` [1] to mark this PR. [1] https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Fri Apr 29 08:09:46 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 29 Apr 2022 08:09:46 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34] In-Reply-To: References:

Message-ID: On Fri, 29 Apr 2022 00:44:01 GMT, Guoxiong Li wrote: > Remind: please use the command `/jep JEP-424` [1] to mark this PR. > > [1] https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep Question: I'm willing to try it out. If something goes wrong - would a `jep unneeded` be enough to "unstuck" this PR? ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From mcimadamore at openjdk.java.net Fri Apr 29 08:15:32 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 29 Apr 2022 08:15:32 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v35] In-Reply-To: References: Message-ID: > This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Tweak Addressable javadoc ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/7888/files - new: https://git.openjdk.java.net/jdk/pull/7888/files/945317ec..d1fcf012 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=34 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7888&range=33-34 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7888.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7888/head:pull/7888 PR: https://git.openjdk.java.net/jdk/pull/7888 From gli at openjdk.java.net Fri Apr 29 08:33:44 2022 From: gli at openjdk.java.net (Guoxiong Li) Date: Fri, 29 Apr 2022 08:33:44 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34] In-Reply-To: References:

Message-ID: On Fri, 29 Apr 2022 08:06:24 GMT, Maurizio Cimadamore wrote: > would a jep unneeded be enough to "unstuck" this PR? Yes if no bug. Conceptually, the `/jep unneeded` will behave as no jep command. ------------- PR: https://git.openjdk.java.net/jdk/pull/7888 From kdnilsen at openjdk.java.net Fri Apr 29 15:01:24 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Fri, 29 Apr 2022 15:01:24 GMT Subject: RFR: Include mixed and abbreviated cycle counts in summary report In-Reply-To: References: Message-ID: On Thu, 28 Apr 2022 20:51:25 GMT, William Kemper wrote: > Include mixed and abbreviated cycle counts in summary report Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/137 From kdnilsen at openjdk.java.net Fri Apr 29 15:03:26 2022 From: kdnilsen at openjdk.java.net (Kelvin Nilsen) Date: Fri, 29 Apr 2022 15:03:26 GMT Subject: RFR: Allow regulator to schedule global cycles for the purpose of class unloading In-Reply-To: References: Message-ID: On Thu, 28 Apr 2022 20:56:42 GMT, William Kemper wrote: > Generational mode only supports class unloading during _global_ cycles. Global cycles can only be triggered in generational mode by an explicit `System.gc` call. With this change, the regulator is able to trigger periodic global cycles based on the value of `ShenandoahUnloadClassesFrequency`. This is currently disabled by default for the generational mode because we've not found a workload that shows a clear benefit, however, we expect it will be needed for longer running workloads and we want the ability to turn this on when necessary. Marked as reviewed by kdnilsen (Committer). ------------- PR: https://git.openjdk.java.net/shenandoah/pull/138 From wkemper at openjdk.java.net Fri Apr 29 15:31:27 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 29 Apr 2022 15:31:27 GMT Subject: Integrated: Allow regulator to schedule global cycles for the purpose of class unloading In-Reply-To: References: Message-ID: On Thu, 28 Apr 2022 20:56:42 GMT, William Kemper wrote: > Generational mode only supports class unloading during _global_ cycles. Global cycles can only be triggered in generational mode by an explicit `System.gc` call. With this change, the regulator is able to trigger periodic global cycles based on the value of `ShenandoahUnloadClassesFrequency`. This is currently disabled by default for the generational mode because we've not found a workload that shows a clear benefit, however, we expect it will be needed for longer running workloads and we want the ability to turn this on when necessary. This pull request has now been integrated. Changeset: b4ad3540 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/b4ad3540ca9f5ca04ab034bc17a4e0c9f0dec2ad Stats: 21 lines in 3 files changed: 15 ins; 1 del; 5 mod Allow regulator to schedule global cycles for the purpose of class unloading Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/138 From wkemper at openjdk.java.net Fri Apr 29 15:32:18 2022 From: wkemper at openjdk.java.net (William Kemper) Date: Fri, 29 Apr 2022 15:32:18 GMT Subject: Integrated: Include mixed and abbreviated cycle counts in summary report In-Reply-To: References: Message-ID: On Thu, 28 Apr 2022 20:51:25 GMT, William Kemper wrote: > Include mixed and abbreviated cycle counts in summary report This pull request has now been integrated. Changeset: 10ebe4e4 Author: William Kemper URL: https://git.openjdk.java.net/shenandoah/commit/10ebe4e429dcf578376b3bd7f61d4f02449c0a35 Stats: 28 lines in 3 files changed: 26 ins; 1 del; 1 mod Include mixed and abbreviated cycle counts in summary report Reviewed-by: kdnilsen ------------- PR: https://git.openjdk.java.net/shenandoah/pull/137 From duke at openjdk.java.net Sat Apr 30 14:11:41 2022 From: duke at openjdk.java.net (ExE Boss) Date: Sat, 30 Apr 2022 14:11:41 GMT Subject: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v35] In-Reply-To: References:

Message-ID: On Fri, 29 Apr 2022 08:15:32 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. >> >> [1] - https://openjdk.java.net/jeps/424 > > Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: > > Tweak Addressable javadoc src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template line 101: > 99: } > 100: > 101: public final static class ScopedAccessError extends Error { This?should probably?use the?canonical modifier?order as?specified in?[JDK?8276348] ([GH?6213]): Suggestion: public static final class ScopedAccessError extends Error { [JDK?8276348]: https://bugs.openjdk.java.net/browse/JDK-8276348 "[JDK?8276348] Use?blessed modifier?order in?java.base" [GH?6213]: https://github.com/openjdk/jdk/pull/6213 ------------- PR: https://git.openjdk.java.net/jdk/pull/7888