RFR: Load balance remembered set scanning [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Mon Aug 1 18:08:45 UTC 2022


On Fri, 29 Jul 2022 16:51:51 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to reviewer comments
>
> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.cpp line 216:
> 
>> 214:       num_groups++;
>> 215: 
>> 216:       if (num_groups >= _num_groups) {
> 
> This is somewhat confusing to read. Is `num_groups` really `groups_created`? and `_num_groups` a target number of groups?

I'm adding a comment and changing num_groups local variable to spanned_groups.

-------------

PR: https://git.openjdk.org/shenandoah/pull/153


More information about the shenandoah-dev mailing list